141 lines
7.8 KiB
Markdown
141 lines
7.8 KiB
Markdown
# Session 0093.0 — Transcript
|
|
|
|
> App: ohm
|
|
> Start: 2026-06-09T03-39 (PST)
|
|
> End: 2026-06-09T04-34 (PST)
|
|
> Type: planning-and-executing
|
|
> Status: **FINALIZED**
|
|
|
|
## Launch prompt
|
|
|
|
```
|
|
Main-view "Ask" should just work (Option B): when the AI Ask affordance
|
|
(selection tooltip + prompt bar) is invoked from an entry's canonical `main`
|
|
view, transparently cut an edit branch (startEditBranch for super-draft /
|
|
promoteToBranch for active — same dispatch as handleStartContributing),
|
|
navigate to that branch + switch to contribute mode so ChatPanel mounts, then
|
|
run the user's question (text + selected quote) as a chat turn once the new
|
|
branch's main_thread_id loads. Non-contributor / signed-out: graceful path, no
|
|
silent no-op, no spurious branch. Flag on main unchanged (discussion thread).
|
|
Frontend tests for the new flow; backend + frontend green. Deploy to OHM after
|
|
(tag + mirror + flotilla); verify on the live rfc-app spec entry.
|
|
Repro: https://rfc.wiggleverse.org/p/rfc-app/c/rfc-app/e/2026-06-08-scoped-admin-ia
|
|
```
|
|
|
|
## Outcome (one line)
|
|
|
|
§8.12/§8.3 main-view AI "Ask" shipped as **v0.54.0** (PR #49) and deployed
|
|
through the full §9 pipeline — tier1 localhost+e2e → PPE+e2e → prod — both PPE
|
|
and OHM prod live and healthy at 0.54.0.
|
|
|
|
## Pre-state
|
|
|
|
- Branch `main` clean at `ff88be2` (v0.53.0, G-15 shipped session 0091).
|
|
- A concurrent session **0092** was in flight on the same checkout (the Scoped
|
|
Admin IA spec — a content-repo surface, no code collision). Per §5.4 this
|
|
session did its edits in an isolated git worktree (`rfc-app-wt-0093`).
|
|
|
|
## The arc
|
|
|
|
1. **Session gate** — classified the prompt as planning-and-executing; claimed
|
|
session **0093** (peeked first: 0080 + 0092 in flight, noted and proceeded
|
|
per the autonomous default). Clean pushed `main` baseline confirmed.
|
|
2. **Root-cause read** (`RFCView.jsx`): the render gate mounts `RFCDiscussionPanel`
|
|
on `main` and `ChatPanel` only on a non-main branch; `submitChatTurn`'s
|
|
optimistic `messages` therefore have nowhere to render on main, and
|
|
`handleTooltipAsk`/`handlePrompt` called it regardless of branch → silent
|
|
no-op. `handleStartContributing` already had the branch-cut dispatch but
|
|
returned void.
|
|
3. **Implementation (Option B), frontend-only:**
|
|
- `handleStartContributing` now **returns** the branch name (new branch on
|
|
main, current branch on a mode-flip, `null` on signed-out / rejected cut).
|
|
- New `handleMainAsk(text, quote)` reuses that dispatch, navigates, and
|
|
stashes `pendingAskRef = {text, quote, branch}`.
|
|
- **Race caught in design:** firing the ask from a *parallel* effect let the
|
|
branch's initial `loadAllMessages(...).then(setMessages)` clobber the
|
|
optimistic turn (the streamed answer would be lost — confirmed it's a real
|
|
bug, not just a test artifact). Fix: fire the stashed ask from **inside the
|
|
message-load effect's `.then`**, after `setMessages(loaded)`, via a live
|
|
`submitChatTurnRef` (keeps the latest closure without widening the effect's
|
|
deps). Guarded on `branchView.branch_name === pending.branch` to avoid the
|
|
stale-main-view transition.
|
|
- `handleTooltipAsk`/`handlePrompt` route to `handleMainAsk` on main, direct
|
|
`submitChatTurn` on a branch. Flag on main unchanged.
|
|
4. **Tests:** new `RFCView.test.jsx` (6 cases: cut+run w/ quote, super-draft uses
|
|
start-edit-branch, existing-branch unchanged, rejected-cut graceful, Flag on
|
|
main, signed-out read-only). New `e2e/main-view-ask.spec.js`. Brought up the
|
|
tier1 stack; the e2e first surfaced that tier1 has **no AI provider** (the turn
|
|
errors with "Chat failed: No AI providers configured", and `submitChatTurn`'s
|
|
error handler swaps in the top-level error page) — which actually *proved* the
|
|
turn fired. Reworked the assertion to the model-independent core (branch cut +
|
|
navigation + turn-fired, matching question-OR-chat-error) so the one spec passes
|
|
in both tier1 (no model) and PPE/prod (model). Local: backend 677 / frontend 66
|
|
/ e2e 5 green.
|
|
5. **SPEC + version:** recorded the behavior in `SPEC.md` §8.3; bumped VERSION +
|
|
`frontend/package.json` to 0.54.0; CHANGELOG 0.54.0 (minor, no operator action).
|
|
6. **Ship:** PR #49 → merged (origin `main`=`f7b93d7`); tagged `v0.54.0` on origin
|
|
AND the `git.benstull.org` mirror + fast-forwarded the mirror's `main` (prod VM
|
|
reads the code tag from the mirror).
|
|
7. **§9 pipeline:** bumped PPE pin `.rfc-app-version.ppe`→0.54.0, `flotilla-core
|
|
deploy rfc-app-ppe` (deploys.id=29, 9/9 ok) → ran `main-view-ask.spec.js`
|
|
against the PPE edge (passed; smoke failed only because PPE has no Mailpit sink
|
|
— expected). Then bumped prod pin `.rfc-app-version`→0.54.0, `flotilla-core
|
|
deploy ohm-rfc-app` (deploys.id=30, 9/9 ok, edge verified).
|
|
8. **Verify:** prod `/api/health`=0.54.0, PPE=0.54.0, repro entry HTTP 200.
|
|
|
|
## Cut state
|
|
|
|
- origin `ben.stull/rfc-app` `main` = `f7b93d7`; tag `v0.54.0` on origin + benstull
|
|
mirror; mirror `main` fast-forwarded.
|
|
- OHM prod live @ **v0.54.0** (`deploys.id=30`); PPE @ **v0.54.0** (`deploys.id=29`).
|
|
- Pins: prod `.rfc-app-version`=0.54.0, PPE `.rfc-app-version.ppe`=0.54.0 (both
|
|
pushed to `ben/ohm-rfc`).
|
|
- Worktree removed; tier1 stack torn down. Local `main` checkout left at `ff88be2`
|
|
(behind origin by 2) — untouched on purpose (concurrent session 0092's checkout).
|
|
- No standalone `writing-plans` artifact (the plan lived in the `## Plan` block
|
|
below for this focused change) → nothing to archive to `plans/`.
|
|
|
|
## Deferred decisions
|
|
|
|
_Autonomous-mode low-confidence calls the driver made and would have
|
|
liked operator input on._
|
|
|
|
- **Contribute mode on the cut branch.** The spec said "switch to contribute
|
|
mode." Honored it (the message-load effect sets contribute on firing the ask)
|
|
since AI chat is an editing activity and contribute surfaces any proposed
|
|
edits — but it's slightly more disruptive than landing in discuss. Easy to flip
|
|
to discuss if the reading-flow feel is preferred.
|
|
- **Prod verification via PPE e2e, not a live in-browser Ask.** A full interactive
|
|
check needs a logged-in contributor and would cut a real edit branch on prod
|
|
dogfood content (a mutating side-effect). Validated end-to-end on the deployed
|
|
**PPE** edge (identical bundle) + prod health + repro 200 instead. The
|
|
click-through on the exact dogfood entry is left to the operator.
|
|
- **PPE jumped 0.52.3→0.54.0** (skipping 0.53.0 — PPE was behind prod). Fine, PPE
|
|
is staging with its own pin, but PPE never ran 0.53.0.
|
|
|
|
## Plan
|
|
|
|
**Goal:** Make the AI "Ask" affordance work from an entry's canonical `main`
|
|
view (Option B) — frontend-only, in `frontend/src/components/RFCView.jsx`.
|
|
|
|
1. `handleStartContributing` → return the new `branch_name`.
|
|
2. New `handleMainAsk(text, quote)`: signed-out → login; else cut+navigate;
|
|
stash `pendingAskRef`.
|
|
3. Pending-ask fires from the message-load effect's `.then` once
|
|
`branchView.branch_name === pending.branch` && `main_thread_id` (avoids the
|
|
stale-main-view race + the late-load clobber); setMode('contribute');
|
|
`submitChatTurn`.
|
|
4. Route `handleTooltipAsk`/`handlePrompt` on `main` → `handleMainAsk`. Flag on
|
|
main unchanged.
|
|
5. Tests: `RFCView.test.jsx` + `e2e/main-view-ask.spec.js`.
|
|
6. Version bump (minor), CHANGELOG, SPEC §8.3, PR→merge.
|
|
7. Deploy PPE→prod (tag + mirror + flotilla), verify.
|
|
|
|
## Next-session prompt
|
|
|
|
The roadmap cursor is unchanged (this was an operator side-quest). Next item:
|
|
|
|
```
|
|
/goal Harden the two §9-surfaced framework fragilities as patch release(s) shipped localhost→PPE→prod: (1) auth.provision_user 500s on a duplicate email (OTC email-row then Gitea-OAuth gitea_id-row, same email) — reconcile by email; (2) the registry/startup reconcile is additive and never prunes removed projects/collections/entries — add safe prune-on-reconcile that must NOT wipe on a transient registry read error. Per project_rfc_app_multiproject.md Next /goal (line ~883).
|
|
```
|