134 lines
7.2 KiB
Markdown
134 lines
7.2 KiB
Markdown
# Session 0049.0 — Transcript
|
||
|
||
> App: dev-claude-plugin
|
||
> Start: 2026-06-10T01-13 (PST) · End: 2026-06-10T01-31 (PST)
|
||
> Type: planning-and-executing
|
||
> Claude-Session: 1598ca65-fd76-468e-9670-e117ffe5adfe
|
||
> Status: FINALIZED
|
||
|
||
## Launch prompt
|
||
|
||
```
|
||
Fix gitea issue #48
|
||
```
|
||
|
||
## Pre-state
|
||
|
||
- `origin/main` at `9b38534`, plugin version **0.34.0** (memory's "0.33.0 latest"
|
||
was one merge stale; verified `ff79cec` ∈ origin/main).
|
||
- Two concurrent in-flight sessions at claim time: 0035 and 0048 (claimed the
|
||
same minute). Canonical checkout parked on `fix/capture-finalize-skip-memory`
|
||
with uncommitted capture drafts (other sessions' loose ends — untouched).
|
||
- Per §5.4, worked in an isolated worktree `/tmp/wgl-dcp-0049-issue48`, branch
|
||
`fix/issue-48-perf-resolver-and-stop-hook` off `origin/main`.
|
||
|
||
## Issue
|
||
|
||
#48 — *Perf: resolve-app.py --name-only fast path / caching + bound
|
||
finalize-on-goal's per-Stop transcript scan* (`type/feature`, `priority/P3`,
|
||
filed by capture session 0035). Acceptance: (1) `--name-only` resolver mode used
|
||
by the notice hooks; (2) optional per-repo cache with documented invalidation;
|
||
(3) tail-bounded `finalize-on-goal` scan, happy-path results unchanged.
|
||
|
||
## Arc
|
||
|
||
1. **Read the code.** Found the costs as described: full resolution = up to five
|
||
`os.walk`s (`find_app_jsons` + 4× `find_local_repo_dir`);
|
||
`finalize-on-goal` = two whole-transcript jq passes per Stop past a leaky
|
||
grep pre-gate. Found a *third* APP_NAME-only resolver caller the issue
|
||
didn't name: `session-end-finalize-guard`.
|
||
2. **Design insight:** `disambiguate`'s own-root precedence makes checking
|
||
`<repo-root>/app.json` first an **exact** short-circuit — a root manifest
|
||
listing its own repo always wins, so the search walk can be skipped with
|
||
zero approximation. Combined with `--name-only` (skip all local-clone walks
|
||
+ the sessions-repo requirement), a self-manifested repo resolves with
|
||
**zero walks** (~40ms, interpreter startup).
|
||
3. **Implemented** the resolver fast paths (docstring documents both + the
|
||
deliberate no-cache decision); adopted `--name-only` in the three hooks.
|
||
4. **Bounded scan:** replaced the jq passes with a python3 scan of only the
|
||
bytes appended since the last scan. Sentinel format upgraded to
|
||
`"<count> <byte-offset>"` (legacy count-only ⇒ offset 0 = one full rescan,
|
||
then upgrades). Offset is a high-water mark advanced on **every** scan;
|
||
complete lines only (a partial tail line waits, un-advanced); transcript
|
||
shorter than the stored offset ⇒ safe full rescan, count never lowered;
|
||
the write-or-skip-nudge loop-safety rule preserved. Per-Stop cost is now
|
||
O(new bytes) even when the grep pre-gate is defeated. Amended the
|
||
2026-06-05 finalize-on-goal design doc (§ "How it works", step 4).
|
||
5. **Cache skipped deliberately** (issue item 2 was optional): the issue's own
|
||
constraint prefers fast-path-without-cache, and own-root already zeroes the
|
||
hot per-repo case. Rationale in the resolver docstring + issue comment 974.
|
||
6. **Tests:** new offline suites `test-resolve-app-fastpath.sh` (6 cases:
|
||
own-root vs empty search root, `--name-only` shape, no-sessions-repo
|
||
tolerance vs full-mode exit 5, walk fallback, non-matching own-root
|
||
fall-through, own-root-beats-foreign) and `test-finalize-goal-scan.sh`
|
||
(10 cases: first/second achievement, no-new-bytes silence, offset advance,
|
||
partial-line deferral, legacy upgrade, shrink reset, noise immunity). All
|
||
green first run; all 5 existing suites green (12+7+8+14+13 = 54) → 70/70.
|
||
Live smokes: `--name-only` ~40ms; `feedback-notice` end-to-end 0.86s.
|
||
7. **Ship race:** bumped 0.34.0→0.35.0, lint clean, pushed — branch was behind
|
||
2: concurrent PR #71 (docs, issue #66 pointer) had taken **0.35.0**.
|
||
Rebased (clean — identical version edit), re-bumped to **0.36.0**, amended,
|
||
`--force-with-lease` push. PR #72 created (default per-host token; the
|
||
issue-scoped token 403s on /pulls), merged `f953610`, remote branch deleted,
|
||
**issue #48 auto-closed** via `Fixes #48`; resolution comment id 974 ticks
|
||
the decomposition (cache item struck through with rationale).
|
||
8. **Incident observed:** at 01:20 (7 min in) the `session-end-finalize-guard`
|
||
appended its ENDED-UNFINALIZED banner to THIS live session's placeholder —
|
||
the harness emitted a SessionEnd with reason `other` mid-session, and the
|
||
guard treats every SessionEnd as terminal. Filed **bug #73** (medium,
|
||
`hooks/session-end-finalize-guard`): ignore non-terminal reasons and/or
|
||
strip stale banners at finalize. The banner was removed from this transcript
|
||
at finalize (this session demonstrably did not end at 01:20).
|
||
9. **Finalize:** plan archived to `plans/2026-06-10-issue-48-perf-fastpaths.md`
|
||
(content repo = the plugin itself, commit `1dfe9d8`). Memory repaired: the
|
||
28.9KB single-line MEMORY.md index (over the 24.4KB limit) shrunk to a
|
||
one-line pointer; session 0043/0044 notes — which lived ONLY in that index
|
||
line — ported into the topic file, 0049 note added.
|
||
|
||
## Pipeline status (§9)
|
||
|
||
Plugin-only change — no deployable UI app, no localhost/PPE/prod stage to run.
|
||
Ship = merge + operator plugin re-install (sessions run the 0.29.0 cache until
|
||
then; the fast paths and bounded scan go live at re-install).
|
||
|
||
## Deferred decisions
|
||
|
||
- **Skipped the optional per-repo resolution cache** (issue #48 item 2). The
|
||
issue's constraint ("cache must never go stale-wrong silently; prefer
|
||
fast-path-without-cache if in doubt") plus the zero-walk own-root path made
|
||
the cache look like risk without proportionate win. Alternative: a cache keyed
|
||
by (repo-root, origin) with re-validation on read. Revisit only if a
|
||
manifest-less repo's session-start latency is ever felt in practice.
|
||
- **`--force-with-lease` push to my own feature branch** after the 0.35.0→0.36.0
|
||
rebase (branch was unshared; lease-protected). Prior sessions saw plain
|
||
force-push denied; lease push was permitted.
|
||
- **Memory index restructure** (porting 0043/0044 out of MEMORY.md into the
|
||
topic file) went beyond the session's nominal scope, but the harness flagged
|
||
the index as over-limit/partially-loaded — leaving it risked future sessions
|
||
silently missing history.
|
||
|
||
## Cut state / operator plate
|
||
|
||
- **Re-install needed** to make 0.36.0 live:
|
||
`claude plugin marketplace update wiggleverse-dev-claude-plugin` +
|
||
`claude plugin update wiggleverse-dev-claude-plugin@wiggleverse-dev-claude-plugin`,
|
||
then restart/`/clear` (cache currently pins 0.29.0).
|
||
- **Worktree removal denied** → `/tmp/wgl-dcp-0049-issue48` and local branch
|
||
`fix/issue-48-perf-resolver-and-stop-hook` (merged) left for the operator:
|
||
`git worktree remove /tmp/wgl-dcp-0049-issue48 && git branch -D fix/issue-48-perf-resolver-and-stop-hook`
|
||
- Pre-existing loose ends untouched: canonical checkout on
|
||
`fix/capture-finalize-skip-memory` (pushed, unmerged) + uncommitted capture
|
||
drafts (`issues/*.md`, INV-8); concurrent sessions 0035/0048 still in flight.
|
||
- New bug **#73** (guard banners live placeholders on SessionEnd reason `other`)
|
||
sits in the feedback pile.
|
||
|
||
## Next-session prompt
|
||
|
||
```
|
||
/goal feedback
|
||
```
|
||
|
||
(Process the open plugin-feedback issues — 5+ untriaged, now including #73;
|
||
the parked Next /goal, carried unconsumed through several explicit-issue
|
||
interrupts including this one.)
|