SLICE-8: Shopify dialect — detect/map Shopify export at the codec boundary + DOC-2/3 (SD-0002 §7.2) #32

2026-06-12T09:37:21Z

ben.stull commented

2026-06-12 09:37:21 +00:00

SLICE-8 — Shopify dialect + public format docs (SD-0002 §7.2)

Closes Products story #13. Completes PUC-6 (a Shopify export imports directly) and PUC-11 (learning the format).

What ships

Header-set dialect detection (detect_dialect / dialect_shopify.is_shopify_header): a file is shopify iff it carries a Shopify-only signature column and no canonical-distinctive column. The canonical veto keeps detection conservative (under-detection warns; over-detection corrupts) — never misparses (§7.4).
Shopify→canonical mapping at the codec boundary (INV-17): renames (Body (HTML)→Description, Product Category→Google Product Category, Cost per item→Variant Cost, Variant Grams→Variant Weight+synth unit g), direct passthroughs, and Shopify columns with no canonical home surfaced as the not-imported warning. Two name-collision overrides: Shopify free-text Type (canonical Type is structural) and Variant Weight Unit (superseded by the grams transform). Exhaustive mapping pinned as a fixture (§6.5.1).
Preview UI: "Shopify product CSV — mapped" label + the existing not-imported columns band; format help links the column reference.
DOC-2 — column reference served at GET /api/products/columns.md.
DOC-3 — sample.csv confirmed final (variants + images, parses clean canonical).
DOC-4 — dialect-adapter dev notes.

Tests

Unit: detection (incl. conservative veto), exhaustive mapping fixture, grams transform + clear, INV-10 over a partial Shopify import.
E2E: e2e_import_shopify_dialect (unmodified Shopify export → mapped banner + not-imported band → confirm → run completes).
Full gate green: import-linter + backend pytest + frontend build/vitest; Playwright 8/8.

Review hardening (adversarial pass)

A canonical file carrying a stray Shopify-signature name (e.g. SEO Title) previously misdetected as Shopify and silently dropped Type / corrupted the weight unit (kg→g). The canonical-distinctive veto closes that, the dual-named shadow (Body (HTML)+Description), and the stale-unit-on-clear case.

Version bump v0.7.0 → v0.8.0.

🤖 Generated with Claude Code

## SLICE-8 — Shopify dialect + public format docs (SD-0002 §7.2) Closes Products story #13. Completes **PUC-6** (a Shopify export imports directly) and **PUC-11** (learning the format). ### What ships - **Header-set dialect detection** (`detect_dialect` / `dialect_shopify.is_shopify_header`): a file is `shopify` iff it carries a Shopify-only *signature* column **and** no canonical-distinctive column. The canonical veto keeps detection conservative (under-detection warns; over-detection corrupts) — never misparses (§7.4). - **Shopify→canonical mapping at the codec boundary** (INV-17): renames (`Body (HTML)`→`Description`, `Product Category`→`Google Product Category`, `Cost per item`→`Variant Cost`, `Variant Grams`→`Variant Weight`+synth unit `g`), direct passthroughs, and Shopify columns with no canonical home surfaced as the not-imported warning. Two name-collision overrides: Shopify free-text `Type` (canonical `Type` is structural) and `Variant Weight Unit` (superseded by the grams transform). Exhaustive mapping pinned as a fixture (§6.5.1). - **Preview UI**: "Shopify product CSV — mapped" label + the existing not-imported columns band; format help links the column reference. - **DOC-2** — column reference served at `GET /api/products/columns.md`. - **DOC-3** — `sample.csv` confirmed final (variants + images, parses clean canonical). - **DOC-4** — dialect-adapter dev notes. ### Tests - Unit: detection (incl. conservative veto), exhaustive mapping fixture, grams transform + clear, INV-10 over a partial Shopify import. - E2E: `e2e_import_shopify_dialect` (unmodified Shopify export → mapped banner + not-imported band → confirm → run completes). - Full gate green: import-linter + backend pytest + frontend build/vitest; Playwright 8/8. ### Review hardening (adversarial pass) A canonical file carrying a stray Shopify-signature name (e.g. `SEO Title`) previously misdetected as Shopify and silently dropped `Type` / corrupted the weight unit (kg→g). The canonical-distinctive veto closes that, the dual-named shadow (`Body (HTML)`+`Description`), and the stale-unit-on-clear case. Version bump v0.7.0 → **v0.8.0**. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

ben.stull added 11 commits 2026-06-12 09:37:21 +00:00

docs(plan): SLICE-8 Shopify dialect implementation plan (SD-0002 §7.2) e16ec7cf94

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat(products): Shopify dialect adapter — header detection + canonical mapping (SD-0002 §6.5.1, SLICE-8) daa237dd59

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat(products): codec detects + maps Shopify dialect at the boundary (INV-17, SLICE-8) 0c7a76a305

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

test(products): exhaustive Shopify->canonical mapping fixture (SD-0002 §6.5.1, SLICE-8) f170950aec

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

test(products): INV-10 holds over a partial Shopify import (SLICE-8) a00f5baaec

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat(products-ui): Shopify 'mapped' label + format help links to column reference (PUC-6/PUC-11, SLICE-8) 0aeccf7d2c

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs(products): DOC-2 column reference served at /api/products/columns.md (SLICE-8) 60a06de302

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs(products): DOC-4 dialect-adapter notes (SLICE-8) 6459e34480

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

test(e2e): e2e_import_shopify_dialect — Shopify export imports directly (PUC-6, SLICE-8) 17f3b600fd

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore(products): SLICE-8 complete — bump v0.8.0; §12 traceability audited (SD-0002) cb6b5996f3

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix(products): conservative dialect detection — canonical-distinctive columns veto Shopify (SLICE-8 review)

ci / check (push) Has been cancelled

Details

ci / check (pull_request) Has been cancelled

Details

a851d3587c

Addresses adversarial-review findings: a canonical file carrying a stray
Shopify-signature name (e.g. SEO Title) no longer misdetects as Shopify and
silently drops canonical Type / corrupts the weight unit (kg->g). A
canonical-distinctive column (Description/Variant Cost/Variant Weight/Google
Product Category/Variant Volume/Tax ID/Position) now vetoes detection, so
detection leans conservative (under-detection warns; over-detection corrupts).
Also closes the dual-named-column shadow (Body (HTML)+Description) and the
stale-weight-unit-on-clear case. Tests cover all three.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

ben.stull merged commit e2d8b5caae into main

2026-06-12 09:37:38 +00:00

ben.stull deleted branch slice-8-shopify-dialect

2026-06-12 09:37:38 +00:00

ben.stull referenced this pull request

2026-06-12 09:41:35 +00:00

Products: bulk CSV import/export — the only data mechanism in the MVP #13

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wiggleverse/wiggleverse-ecomm#32