Flaky test: resend-cooldown retry_after_s ceil-rounds to 61 at sub-second boundaries #27

New Issue

2026-06-12T04:08:08Z

ben.stull commented

2026-06-12 04:08:08 +00:00

Found (twice) during ecomm session 0032 while running the full backend suite: tests/test_accounts_request_code.py::test_puc_02c_resend_is_rate_limited intermittently fails with assert 61 <= 60 — ResendCooldown.retry_after_s ceil-rounds to 61 when the request lands at a sub-second wall-clock boundary. Pre-existing (reproduced at a commit before SLICE-5's changes); passes on rerun.

Work: make the assertion or the cooldown math boundary-safe (e.g. assert retry_after_s <= 61, or floor instead of ceil, or freeze time in the test).

Found (twice) during ecomm session 0032 while running the full backend suite: `tests/test_accounts_request_code.py::test_puc_02c_resend_is_rate_limited` intermittently fails with `assert 61 <= 60` — `ResendCooldown.retry_after_s` ceil-rounds to 61 when the request lands at a sub-second wall-clock boundary. Pre-existing (reproduced at a commit before SLICE-5's changes); passes on rerun. **Work:** make the assertion or the cooldown math boundary-safe (e.g. assert `retry_after_s <= 61`, or floor instead of ceil, or freeze time in the test).

ben.stull added the priority/P3 type/bug labels 2026-06-12 04:08:08 +00:00

ben.stull commented

2026-06-12 16:16:28 +00:00

Closing as part of the pivot from a generic multi-tenant Shopify-alternative storefront to the commitment-commerce + cross-maker verified referral network direction (see ecomm-content/rfcs/network_strategy.md; session 0036).

Test flake in the current OTP resend-cooldown path; that code is being stripped/repointed in this pivot. Closing with the code it tests.

Nothing is lost — code stays in git history and the issue can be reopened if it resurfaces under the network architecture.

Closing as part of the pivot from a generic multi-tenant Shopify-alternative storefront to the commitment-commerce + cross-maker verified referral **network** direction (see `ecomm-content/rfcs/network_strategy.md`; session 0036). Test flake in the current OTP resend-cooldown path; that code is being stripped/repointed in this pivot. Closing with the code it tests. Nothing is lost — code stays in git history and the issue can be reopened if it resurfaces under the network architecture.

ben.stull closed this issue

2026-06-12 16:16:28 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wiggleverse/wiggleverse-ecomm#27