update ecomm/0033/SESSION-0033.0-TRANSCRIPT-2026-06-11T21-31--INPROGRESS.md
This commit is contained in:
@@ -46,8 +46,44 @@ Plan written (14 tasks) →
|
|||||||
snapshot the diff engine reads; INV-12 locked by a 200-catalog property
|
snapshot the diff engine reads; INV-12 locked by a 200-catalog property
|
||||||
test + `e2e_roundtrip_noop`. Executing subagent-driven.
|
test + `e2e_roundtrip_noop`. Executing subagent-driven.
|
||||||
|
|
||||||
|
## Implementation outcome (pre-ship checkpoint)
|
||||||
|
|
||||||
|
SLICE-6 built subagent-driven (13 commits on `worktree-slice-6-export-roundtrip`,
|
||||||
|
off `main` @ 011f4d5 / v0.5.0). What landed:
|
||||||
|
- **`serialize.py`** — canonical serializer (one codec, two directions): the
|
||||||
|
`CatalogProduct` snapshot → canonical CSV, inverse of codec/validate, §6.5.1
|
||||||
|
row grammar (product fields + option names on row 0, variant-per-row, images
|
||||||
|
interleaved, image-only rows, no Option*Value for no-option products).
|
||||||
|
- **`repo.export_catalog`** (status-filtered, sorted snapshot) +
|
||||||
|
**`service.export_catalog`** (streamed, eager `EmptyCatalog`, TEL-3
|
||||||
|
`catalog_exported`) + **`GET /api/products/export`** (StreamingResponse,
|
||||||
|
409 empty_catalog, 422 bad status).
|
||||||
|
- **Frontend** export status-filter menu on the Products page (native
|
||||||
|
`<details>` disclosure; disabled-with-note when empty); `exportUrl` /
|
||||||
|
`EXPORT_STATUSES` / `isExportEnabled` helpers.
|
||||||
|
- **INV-12 locked** by a 200-catalog property test + 2 E2E
|
||||||
|
(`e2e_export_download`, `e2e_roundtrip_noop`). DOC-1/DOC-4 updated. v0.6.0.
|
||||||
|
- **Final code review caught a real INV-12 bug** the green tests missed:
|
||||||
|
`Variant Position` is a `CatalogVariant` attribute (not a `fields{}` entry),
|
||||||
|
so the serializer emitted an empty cell → re-import reset position to file
|
||||||
|
order → non-sequential stored positions round-tripped to a spurious update.
|
||||||
|
Fixed (emit `str(variant.position)`); property generator strengthened to
|
||||||
|
non-sequential positions + targeted regression test. The bug was reproduced,
|
||||||
|
fixed TDD (red→green), re-verified.
|
||||||
|
|
||||||
|
Gates: `check.sh` green (lint-imports, 166 backend pytest, frontend build,
|
||||||
|
14 vitest); `e2e.sh` 6/6 green. Next: push → PR → merge → tag v0.6.0 +
|
||||||
|
release tag → flotilla PPE deploy → PPE smoke.
|
||||||
|
|
||||||
## Deferred decisions
|
## Deferred decisions
|
||||||
|
|
||||||
|
- **Task 9 RTL-vs-pure-helper** (plan's adaptive point): repo has no
|
||||||
|
`@testing-library/react`/jsdom and uses pure-logic `.test.ts` only — took the
|
||||||
|
pure-helper path (`exportMenu.ts` + `.test.ts`), JSX verified by E2E. Avoided
|
||||||
|
dragging in a test framework as a slice side effect (matches SLICE-2/3).
|
||||||
|
- **Stale frontend lockfile**: `package-lock.json` was at 0.4.0 (SLICE-5 bumped
|
||||||
|
package.json but not the lock); `npm version 0.6.0` synced both. Harmless.
|
||||||
|
|
||||||
_Autonomous-mode low-confidence calls the driver made and would have
|
_Autonomous-mode low-confidence calls the driver made and would have
|
||||||
liked operator input on. Appended as the session runs; surfaced at
|
liked operator input on. Appended as the session runs; surfaced at
|
||||||
finalize. Empty if none._
|
finalize. Empty if none._
|
||||||
|
|||||||
Reference in New Issue
Block a user